Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) restore Codecov support alongside Coveralls #410

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

thibaultcha
Copy link
Member

Codecov has a couple features that Coveralls lacks: better PR comments and PR diff comments of uncovered lines. It's also easier to maintain compared to the carryforward flags of Coveralls.

@coveralls
Copy link

coveralls commented Sep 11, 2023

Pull Request Test Coverage Report for Build 6175467877

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 91.088%

Totals Coverage Status
Change from base Build 6174713585: 0.002%
Covered Lines: 7584
Relevant Lines: 8326

💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #410 (7c4c2a4) into main (57d07a1) will increase coverage by 13.9033%.
Report is 303 commits behind head on main.
The diff coverage is 90.5703%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##               main       #410         +/-   ##
=================================================
+ Coverage   76.3716%   90.2749%   +13.9033%     
=================================================
  Files            43         46          +3     
  Lines          7072       8401       +1329     
  Branches       1281          0       -1281     
=================================================
+ Hits           5401       7584       +2183     
+ Misses          934        817        -117     
+ Partials        737          0        -737     
Files Changed Coverage Δ
src/common/shm/ngx_wasm_shm.h 100.0000% <ø> (ø)
src/http/proxy_wasm/ngx_http_proxy_wasm.h 90.0000% <ø> (+10.0000%) ⬆️
src/wasm/ngx_wasm.h 100.0000% <ø> (+11.1111%) ⬆️
src/wasm/vm/ngx_wavm.h 92.3076% <ø> (+26.5182%) ⬆️
src/wasm/wrt/ngx_wrt_wasmtime.c 84.3971% <ø> (+13.6994%) ⬆️
src/common/lua/ngx_wasm_lua_resolver.c 74.0740% <74.0740%> (ø)
src/common/lua/ngx_wasm_lua.c 77.4725% <77.4725%> (ø)
src/common/ngx_wasm_socket_tcp_readers.c 86.6972% <83.3333%> (+15.1286%) ⬆️
src/http/ngx_http_wasm_util.c 85.8044% <83.8709%> (+25.6620%) ⬆️
src/wasm/wrt/ngx_wrt_wasmer.c 81.3888% <85.4545%> (+10.0073%) ⬆️
... and 27 more

... and 8 files with indirect coverage changes

Codecov has a couple features that Coveralls lacks: better PR comments
and PR diff comments of uncovered lines. It's also easier to maintain
compared to the `carryforward` flags of Coveralls.
Attempted to be re-enabled in #408 but unfortunately the nature of the
test makes it flaky in Valgrind CI.
@thibaultcha thibaultcha merged commit 3bea432 into main Sep 14, 2023
@thibaultcha thibaultcha deleted the chore/codecov branch September 14, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants